Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add CONTIBUTING.md #69

Merged
merged 5 commits into from
Jan 11, 2019
Merged

docs: Add CONTIBUTING.md #69

merged 5 commits into from
Jan 11, 2019
+793 −132

Conversation

Esemesek
Copy link
Member

@Esemesek Esemesek commented Jan 9, 2019

This PR includes:

  • - Adding CONTRIBUTING.md
  • - Setting up husky with commitlint to force meaningul commit messages

Fixes #62

@Esemesek Esemesek requested a review from grabbou January 9, 2019 22:07
grabbou
grabbou reviewed Jan 10, 2019
View reviewed changes
Copy link
Member

@grabbou grabbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the PR. Leaving few ideas!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@thymikee thymikee merged commit c0780b8 into react-native-community:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grabbou grabbou grabbou left review comments

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Esemesek @grabbou @thymikee